Remove sensitive data from debug logs#50
Open
Catafal wants to merge 1 commit intofarzaa:mainfrom
Open
Conversation
Seven print statements were logging PII and security-sensitive values: - User speech transcripts verbatim (CompanionManager.swift) - AssemblyAI bearer token prefix (AssemblyAIStreamingTranscriptionProvider.swift) - Screen element labels and pixel coordinates (CompanionManager.swift x3, ElementLocationDetector.swift x2) Fixes: - Token log → "fetched temporary token (OK)" (no token content) - Transcript log → char count only (no speech content) - Element/coordinate logs → replaced with content-free status messages Low-severity logs (lifecycle events, error descriptions, payload sizes) are unchanged. Fixes farzaa#44 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi, Although debug prints were sanitized, the PR still routes sensitive values (full transcript, full AI response, UI element labels) into analytics capture calls, which remains a high-risk data exfiltration path. This contradicts the stated goal of removing PII/security-sensitive runtime data from outputs. Severity: remediation recommended | Category: security How to fix: Stop sending raw PII to analytics Agent prompt to fix - you can give this to your LLM of choice:
Found by Qodo code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Remove PII and security-sensitive values from debug print statements (resolves #44)
Problem
Seven
print()calls were writing sensitive runtime data to the system log, visible in Console.app to anyone with local machine access:AssemblyAIStreamingTranscriptionProvider.swift:44CompanionManager.swift:522CompanionManager.swift:679CompanionManager.swift:681CompanionManager.swift:1020ElementLocationDetector.swift:113–116ElementLocationDetector.swift:257Changes
AssemblyAIStreamingTranscriptionProvider.swift"fetched temporary token (abc123prefix...)"→"fetched temporary token (OK)"CompanionManager.swift"received transcript: <user's words>"→"received transcript (N chars)""pointing at element"ElementLocationDetector.swiftWhat was NOT changed
All low-severity logs (lifecycle events, error descriptions, payload sizes, provider names) are unchanged — they contain no user data and are useful for debugging.
Testing
Closes #44